Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update example of String Format instead of just round trip #790

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

BenjaminMichaelis
Copy link
Member

@BenjaminMichaelis BenjaminMichaelis commented Aug 28, 2024

Changes example to just show off String Format specifiers instead of just Round Trip format - this will support doc changes

Using CultureInfo as we are in an advanced block

References:

@BenjaminMichaelis
Copy link
Member Author

BenjaminMichaelis commented Aug 28, 2024

I was tossing back and forth the idea of adding another ToString with explicitly setting US format in case we have a reader from FR - but that seemed maybe overkill and adding clutter while not adding much value. Thoughts?

@BenjaminMichaelis BenjaminMichaelis enabled auto-merge (squash) September 12, 2024 21:14
@BenjaminMichaelis BenjaminMichaelis force-pushed the BMichaelis/Update2.9Sample branch from e23a494 to 1ec953f Compare September 12, 2024 21:27
@BenjaminMichaelis BenjaminMichaelis force-pushed the BMichaelis/Update2.9Sample branch from 1ec953f to 9d9dbb7 Compare September 12, 2024 22:29
@BenjaminMichaelis BenjaminMichaelis merged commit a10335b into v12.0 Sep 12, 2024
6 checks passed
@BenjaminMichaelis BenjaminMichaelis deleted the BMichaelis/Update2.9Sample branch September 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants